Fixing typo in comment in md32_common.h #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing a typo in the comment in md32_common.h The <chaining length> is 32 bytes (= 256 bits) for SHA-224 and SHA-256, and 64 bytes (= 512 bits) for SHA-384 and SHA-512. See also https://github.com/aws/aws-lc/blob/0a470e450c6f5492478319abefc6daa0e9999954/include/openssl/sha.h#L174 .
WillChilds-Klein
approved these changes
Feb 26, 2024
torben-hansen
approved these changes
Feb 27, 2024
| @@ -76,7 +76,7 @@ extern "C" { | |||
| // } <NAME>_CTX; | |||
| // | |||
| // <chaining length> is the output length of the hash in bytes, before | |||
| // any truncation (e.g. 64 for SHA-224 and SHA-256, 128 for SHA-384 and | |||
| // any truncation (e.g. 32 for SHA-224 and SHA-256, 64 for SHA-384 and | |||
There was a problem hiding this comment.
The above struct template+description is also not correct for SHA[384,512] that use 64-bit chunks, not 32-bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fixing a typo in the comment in md32_common.h
The is 32 bytes (= 256 bits) for SHA-224 and SHA-256, and 64 bytes (= 512 bits) for SHA-384 and SHA-512. See also
aws-lc/include/openssl/sha.h
Lines 174 to 179 in 0a470e4
Call-outs:
N/A
Testing:
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.