Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding No-op functions required for NodeJS compatability #1474

Merged
merged 6 commits into from
Mar 20, 2024

Conversation

smittals2
Copy link
Contributor

@smittals2 smittals2 commented Mar 5, 2024

Description of changes:

Added OPENSSL_init and SSL_CTX_set_dh_auto as no-op functions to support compilation with NodeJS. OPENSSL_init does nothing by design and SSL_CTX_set_dh_auto because DH is not supported with SSL in AWS-LC.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@smittals2 smittals2 requested a review from a team as a code owner March 5, 2024 21:43
ssl/ssl_lib.cc Show resolved Hide resolved
include/openssl/ssl.h Outdated Show resolved Hide resolved
crypto/crypto.c Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 76.98%. Comparing base (0a470e4) to head (bcf863a).
Report is 45 commits behind head on main.

Files Patch % Lines
ssl/ssl_lib.cc 0.00% 2 Missing ⚠️
crypto/crypto.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1474      +/-   ##
==========================================
+ Coverage   76.92%   76.98%   +0.05%     
==========================================
  Files         425      425              
  Lines       71571    71630      +59     
==========================================
+ Hits        55055    55141      +86     
+ Misses      16516    16489      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smittals2 smittals2 requested review from andrewhop and a team March 9, 2024 00:50
crypto/bio/bio_mem.c Outdated Show resolved Hide resolved
include/openssl/bio.h Outdated Show resolved Hide resolved
include/openssl/ssl.h Outdated Show resolved Hide resolved
@smittals2 smittals2 merged commit c187b23 into aws:main Mar 20, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants