Support reading additional data from underlying BIO for each call to SSL_read #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhop
force-pushed
the
read_ahead
branch
2 times, most recently
from
4d01669
to
f325b72
Compare
skmcgrail
reviewed
Apr 2, 2024
…SSL_read: * SSL_set_read_ahead * SSL_CTX_set_read_ahead * SSL_set_default_read_buffer_len * SSL_CTX_set_default_read_buffer_len By enabling read ahead the system may reduce the number of calls to the SSL read BIO by reading more data than is specified in the TLS record header.
skmcgrail
approved these changes
May 3, 2024
WillChilds-Klein
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves P116480532
Description of changes:
Fully support:
Call-outs:
By enabling read ahead the system may reduce the number of calls to the SSL read BIO by reading more data than is specified in the TLS record header per call to the BIO which may improve performance.
Testing:
Added new unit tests and integration tests for this change. Also manually verified the number of calls to the read BIO.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.