Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for compiling w/ Clang on Windows #1520

Closed
wants to merge 3 commits into from
Closed

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Apr 9, 2024

Description of changes:

  • Sets up a Windows CI task to build on that platform with Clang 16.
  • Fixes a build failure that seems to only occur when building with Clang on Windows:
D:/a/aws-lc/aws-lc/tool/../third_party/jitterentropy/arch/jitterentropy-base-windows.h:64:13: error: unused function 'jent_get_nstime' [-Werror,-Wunused-function]

static void jent_get_nstime(uint64_t *out)

            ^

1 error generated.

Call-outs:

  • Although Clang is used to compile C/C++, the build still uses NASM for the assembly.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth force-pushed the windows-clang branch 2 times, most recently from abf3227 to 9339f11 Compare April 9, 2024 17:11
@justsmth justsmth changed the title [DRAFT] CI for compiling w/ Clang on Windows CI for compiling w/ Clang on Windows Apr 9, 2024
@justsmth justsmth marked this pull request as ready for review April 9, 2024 20:05
@justsmth justsmth requested a review from a team as a code owner April 9, 2024 20:05
justsmth added a commit to justsmth/aws-lc that referenced this pull request Apr 10, 2024
@justsmth justsmth closed this Apr 10, 2024
@justsmth justsmth deleted the windows-clang branch May 16, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants