Release build for MinGW CI; Fix GCC 12/13 warnings #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
force-pushed
the
maybe-uninit-fail
branch
from
85082d4 to
29f1362
Compare
justsmth
changed the title
| for (size_t i = 0; i < len; i++) { | ||
| // GCC 12/13 report `stringop-overflow` on the following line | ||
| // without additional condition: `i < sizeof(int64_t)` | ||
| for (size_t i = 0; i < len && i < sizeof(int64_t); i++) { |
There was a problem hiding this comment.
huh, that can already be deduced from (len > sizeof(int64_t)....
There was a problem hiding this comment.
Yes, I believe so. But gcc-13 seems to think otherwise:
/Users/justsmth/repos/aws-lc/crypto/bytestring/cbs.c: In function 'CBS_get_asn1_int64':
/Users/justsmth/repos/aws-lc/crypto/bytestring/cbs.c:534:20: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
534 | sign_extend[i] = data[len - i - 1];
| ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
/Users/justsmth/repos/aws-lc/crypto/bytestring/cbs.c:521:11: note: at offset 8 into destination object 'sign_extend' of size 8
521 | uint8_t sign_extend[sizeof(int64_t)];
| ^~~~~~~~~~~
¯\_(ツ)_/¯
| @@ -442,7 +442,7 @@ ECDSA_SIG *ecdsa_digestsign_no_self_test(const EVP_MD *md, const uint8_t *input, | |||
| const uint8_t *nonce, | |||
| size_t nonce_len) { | |||
| uint8_t digest[EVP_MAX_MD_SIZE]; | |||
| unsigned int digest_len; | |||
| unsigned int digest_len = EVP_MAX_MD_SIZE; | |||
There was a problem hiding this comment.
I believe EVP_MAX_MD_SIZE is correct. This value gets dereferenced as the len parameter in the call to EVP_DigestFinalXOF.
torben-hansen
approved these changes
Apr 17, 2024
dkostic
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves:
x86_64-pc-windows-gnuTarget due to Uninitialized Variables inaws-lcaws-lc-rs#397Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.