Implement DEPRECATED RSA_pkey_ctx_ctrl #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[AWS-LC][3] and [OpenSSL 3][4] implement various RSA control functions as concrete functions, but OpenSSL 1.1.1 [implements][1] them as macros calling `RSA_pkey_ctx_ctrl`. This commit provides an implementation of `RSA_pkey_ctx_ctrl` [directly cribbed][1] from OpenSSL 1.1.1, and identical to OpenSSL 3's implementation [today][2]. [1]: openssl/openssl@e5e04ee [2]: https://github.com/openssl/openssl/blob/067fbc01b9e867b31c71091d62f0f9012dc9e41a/crypto/rsa/rsa_lib.c#L734 [3]: https://github.com/aws/aws-lc/blob/2c03113451b5f84f61c8ed283b289a6db87b3397/include/openssl/evp.h#L796 [4]: https://github.com/openssl/openssl/blob/067fbc01b9e867b31c71091d62f0f9012dc9e41a/include/openssl/rsa.h#L125
WillChilds-Klein
force-pushed
the
RSA_pkey_ctx_ctrl
branch
from
bde1d56
to
59afb43
Compare
WillChilds-Klein
force-pushed
the
RSA_pkey_ctx_ctrl
branch
from
72ef7d6
to
1c2fccb
Compare
torben-hansen
previously approved these changes
May 3, 2024
justsmth
reviewed
May 3, 2024
justsmth
approved these changes
May 3, 2024
torben-hansen
approved these changes
May 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1575 +/- ##
==========================================
+ Coverage 77.43% 77.45% +0.02%
==========================================
Files 435 435
Lines 71820 71827 +7
==========================================
+ Hits 55615 55635 +20
+ Misses 16205 16192 -13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
AWS-LC and OpenSSL 3 implement various RSA control functions
as concrete functions, but OpenSSL 1.1.1 implements them as macros
calling
RSA_pkey_ctx_ctrl. This commit provides an implementation ofRSA_pkey_ctx_ctrldirectly cribbed from OpenSSL 1.1.1, andidentical to OpenSSL 3's implementation today.
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.