Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More minor symbols for Ruby support #1581

Merged
merged 8 commits into from
Jun 14, 2024
Merged

Conversation

samuel40791765
Copy link
Contributor

Issues:

Addresses CryptoAlg-1717

Description of changes:

This implements two minor symbols and a few no-op flags for Ruby support.

New symbols:

  • PKCS12_new
  • CONF_get1_default_config_file

No-op flags:

  • SSL_OP_CRYPTOPRO_TLSEXT_BUG
  • SSL_OP_SAFARI_ECDHE_ECDSA_BUG
  • SSL_OP_TLSEXT_PADDING

Call-outs:

All of these no-ops are following a precedent in AWS-LC. We may have to have a discussion on whether to support CONF modules further down the line, but exposing this as a no-op for now.

Testing:

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

crypto/pkcs8/pkcs8_x509.c Show resolved Hide resolved
crypto/conf/conf.c Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.15%. Comparing base (e7e64f8) to head (de56c61).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1581      +/-   ##
==========================================
- Coverage   78.15%   78.15%   -0.01%     
==========================================
  Files         562      562              
  Lines       94676    94683       +7     
  Branches    13576    13576              
==========================================
+ Hits        73995    73998       +3     
- Misses      20084    20089       +5     
+ Partials      597      596       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuel40791765 samuel40791765 force-pushed the pkcs12_new branch 2 times, most recently from 35b0e8d to f376e4e Compare May 24, 2024 00:19
crypto/conf/conf.c Outdated Show resolved Hide resolved
crypto/conf/conf.c Outdated Show resolved Hide resolved
docs/porting/configuration-differences.md Show resolved Hide resolved
include/openssl/conf.h Show resolved Hide resolved
include/openssl/ssl.h Show resolved Hide resolved
include/openssl/ssl.h Show resolved Hide resolved
@samuel40791765 samuel40791765 merged commit 98735a2 into aws:main Jun 14, 2024
96 of 98 checks passed
@samuel40791765 samuel40791765 deleted the pkcs12_new branch June 14, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants