Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for X509_CRL_http_nbio #1596

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

samuel40791765
Copy link
Contributor

Issues:

Resolves CryptoAlg-1648

Description of changes:

X509_CRL_http_nbio is the last API needed to support the AzureSDK after implementation of 7ef93cb. It's a simple wrapper around an existing API, so might as well add support so we can resolve the ticket.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth
Copy link
Contributor

Something is missing in this PR...

https://github.com/aws/aws-lc/actions/runs/9086321401/job/24971726741?pr=1596#step:3:303

In file included from /home/runner/work/aws-lc/aws-lc/include/openssl/ocsp.h:15,
                 from /home/runner/work/aws-lc/aws-lc/crypto/ocsp/internal.h:10,
                 from /home/runner/work/aws-lc/aws-lc/crypto/ocsp/ocsp_asn.c:13:
/home/runner/work/aws-lc/aws-lc/include/openssl/x509.h:815:39: error: unknown type name ‘OCSP_REQ_CTX’
  815 | OPENSSL_EXPORT int X509_CRL_http_nbio(OCSP_REQ_CTX *rctx, X509_CRL **pcrl);
      |                                       ^~~~~~~~~~~~

@justsmth justsmth marked this pull request as draft May 15, 2024 12:34
@samuel40791765 samuel40791765 marked this pull request as ready for review May 15, 2024 17:21
@samuel40791765
Copy link
Contributor Author

Something is missing in this PR...

My bad haha

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 78.04%. Comparing base (92bf532) to head (2c34afe).

Files Patch % Lines
crypto/x509/x_all.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1596   +/-   ##
=======================================
  Coverage   78.03%   78.04%           
=======================================
  Files         562      562           
  Lines       94556    94558    +2     
  Branches    13574    13574           
=======================================
+ Hits        73786    73795    +9     
+ Misses      20175    20171    -4     
+ Partials      595      592    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth merged commit ffbf2da into aws:main May 30, 2024
89 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants