Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X509toolcomparison #1714

Merged
merged 39 commits into from
Jul 24, 2024
Merged

X509toolcomparison #1714

merged 39 commits into from
Jul 24, 2024

Conversation

ecdeye
Copy link
Contributor

@ecdeye ecdeye commented Jul 18, 2024

Description:
Refactored existing x509 tests
Added OpenSSL comparison tests and CI script

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 72 lines in your changes missing coverage. Please review.

Project coverage is 78.35%. Comparing base (181eb7d) to head (110eb35).

Files Patch % Lines
tool-openssl/x509_test.cc 50.00% 67 Missing and 2 partials ⚠️
tool-openssl/x509.cc 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1714      +/-   ##
==========================================
- Coverage   78.35%   78.35%   -0.01%     
==========================================
  Files         573      573              
  Lines       96059    96123      +64     
  Branches    13763    13781      +18     
==========================================
+ Hits        75268    75318      +50     
- Misses      20190    20200      +10     
- Partials      601      605       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ecdeye ecdeye marked this pull request as ready for review July 19, 2024 05:03
@ecdeye ecdeye requested a review from a team as a code owner July 19, 2024 05:03
smittals2
smittals2 previously approved these changes Jul 23, 2024
tests/ci/run_openssl_comparison_tests.sh Outdated Show resolved Hide resolved
tool-openssl/x509.cc Outdated Show resolved Hide resolved
tool-openssl/x509_test.cc Show resolved Hide resolved
Co-authored-by: Samuel Chiang <sachiang@amazon.com>
@ecdeye ecdeye enabled auto-merge (squash) July 24, 2024 15:27
@ecdeye ecdeye disabled auto-merge July 24, 2024 16:33
@ecdeye ecdeye merged commit f723a0c into aws:main Jul 24, 2024
104 checks passed
skmcgrail added a commit that referenced this pull request Aug 1, 2024
## What's Changed
* Added options to x509 tool by @ecdeye in
#1696
* Add support to detect Neoverse V2 cores by @andrewhop in
#1706
* Move OCSP functions for Ruby out of internal.h by @samuel40791765 in
#1704
* Add aes-256-xts to EVP_get_cipherbyname by @torben-hansen in
#1707
* Match using CMAKE_SYSTEM_PROCESSOR_LOWER by @justsmth in
#1709
* Update MySQL to 9.0.0 by @skmcgrail in
#1685
* [EC] Unify scalar multiplication for P-256/384/521 by @dkostic in
#1693
* Adds const qualifier to ciphertext parameter in EVP_PKEY_decapsulate
by @maddeleine in #1713
* Upstream merge 2024 06 24 by @nebeid in
#1661
* NIST SP 800-108r1-upd1: KDF Counter Implementation by @skmcgrail in
#1644
* Upstream merge 2024 07 09 by @nebeid in
#1694
* Design for support of HMAC precomputed keys by @fabrice102 in
#1574
* Fix for select point from table in ec_nistp scalar_mul by @dkostic in
#1719
* X509toolcomparison by @ecdeye in
#1714
* AWS-LC s2n-bignum update 2024-07-22 by @dkostic in
#1718
* Add OpenVPN to CI by @smittals2 in
#1705
* Lower required Go version, add CI test for specific version by
@andrewhop in #1717
* ec2-test-framework enhancements and graviton 4 testing by
@samuel40791765 in #1715
* sha + chacha: Move AArch64/X86-64 dispatching to C. by @justsmth in
#1625
* Show number of pruned ec2 instances in dashboard by @samuel40791765 in
#1728
* rsa and md5 tools by @ecdeye in
#1722
* FIPS 203 IPD update: ML-KEM-IPD-768 and ML-KEM-IPD-1024 by @jakemas in
#1724
* bump mysql CI to 9.0.1 by @samuel40791765 in
#1727
* Support utility OCSP request functions by @samuel40791765 in
#1708
* add support for OCSP_SINGLERESP functions by @samuel40791765 in
#1703
samuel40791765 pushed a commit to samuel40791765/aws-lc that referenced this pull request Aug 14, 2024
Description:
Refactored existing x509 tests
Added OpenSSL comparison tests and CI script

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.

---------

Co-authored-by: Samuel Chiang <sachiang@amazon.com>
(cherry picked from commit f723a0c)
samuel40791765 pushed a commit that referenced this pull request Aug 15, 2024
Description:
Refactored existing x509 tests
Added OpenSSL comparison tests and CI script

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.

---------

Co-authored-by: Samuel Chiang <sachiang@amazon.com>
(cherry picked from commit f723a0c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants