Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add OCSP_response_create and OCSP_basic_add1_status #1732

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

samuel40791765
Copy link
Contributor

Issues:

Addresses CryptoAlg-2420

Description of changes:

Add support for OCSP_response_create and OCSP_basic_add1_status. As we've noted before, these functions are used as OCSP responder functions and Ruby happens to depend on them in their OCSP module.
This builds upon the existing ASN.1 infrastructure we already have for creating OCSP structures. The two APIs allow for the user to specify relevant fields while creating the OCSP structures.

Call-outs:

New error codes were introduced, 1 from OpenSSL (OCSP_R_NO_REVOKED_TIME) and 1 new code that is used when an invalid field value is used (OCSP_R_UNKNOWN_FIELD_VALUE).

Testing:

New tests for both function

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@samuel40791765 samuel40791765 requested a review from a team as a code owner August 1, 2024 00:27
@samuel40791765 samuel40791765 marked this pull request as draft August 1, 2024 00:27
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 80.46875% with 25 lines in your changes missing coverage. Please review.

Project coverage is 78.33%. Comparing base (3c69611) to head (dab8d45).

Files Patch % Lines
crypto/ocsp/ocsp_server.c 70.58% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1732      +/-   ##
==========================================
+ Coverage   78.31%   78.33%   +0.02%     
==========================================
  Files         580      580              
  Lines       97143    97252     +109     
  Branches    13928    13947      +19     
==========================================
+ Hits        76075    76181     +106     
- Misses      20446    20451       +5     
+ Partials      622      620       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crypto/ocsp/ocsp_server.c Show resolved Hide resolved
include/openssl/ocsp.h Show resolved Hide resolved
justsmth
justsmth previously approved these changes Aug 15, 2024
@torben-hansen torben-hansen self-requested a review August 15, 2024 20:02
crypto/ocsp/ocsp_server.c Outdated Show resolved Hide resolved
crypto/ocsp/ocsp_server.c Outdated Show resolved Hide resolved
crypto/ocsp/ocsp_server.c Show resolved Hide resolved
crypto/ocsp/ocsp_test.cc Show resolved Hide resolved
torben-hansen
torben-hansen previously approved these changes Aug 21, 2024
justsmth
justsmth previously approved these changes Aug 21, 2024
@samuel40791765 samuel40791765 enabled auto-merge (squash) August 21, 2024 21:05
@samuel40791765 samuel40791765 merged commit 7d3101f into aws:main Aug 21, 2024
105 of 106 checks passed
@samuel40791765 samuel40791765 deleted the ocsp-resp-create branch August 21, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants