-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add OCSP_response_create and OCSP_basic_add1_status #1732
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1732 +/- ##
==========================================
+ Coverage 78.31% 78.33% +0.02%
==========================================
Files 580 580
Lines 97143 97252 +109
Branches 13928 13947 +19
==========================================
+ Hits 76075 76181 +106
- Misses 20446 20451 +5
+ Partials 622 620 -2 ☔ View full report in Codecov by Sentry. |
samuel40791765
force-pushed
the
ocsp-resp-create
branch
from
August 1, 2024 22:28
b53cd54
to
712afc9
Compare
samuel40791765
force-pushed
the
ocsp-resp-create
branch
from
August 1, 2024 22:35
712afc9
to
326eab4
Compare
justsmth
reviewed
Aug 6, 2024
samuel40791765
force-pushed
the
ocsp-resp-create
branch
from
August 13, 2024 20:14
326eab4
to
b709724
Compare
justsmth
previously approved these changes
Aug 15, 2024
samuel40791765
force-pushed
the
ocsp-resp-create
branch
from
August 21, 2024 19:06
41ba3db
to
968ef0d
Compare
samuel40791765
force-pushed
the
ocsp-resp-create
branch
from
August 21, 2024 19:43
968ef0d
to
fd100a1
Compare
torben-hansen
previously approved these changes
Aug 21, 2024
justsmth
previously approved these changes
Aug 21, 2024
samuel40791765
dismissed stale reviews from justsmth and torben-hansen
via
August 21, 2024 21:15
dab8d45
torben-hansen
approved these changes
Aug 21, 2024
justsmth
approved these changes
Aug 21, 2024
lilpoozie2005
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses
CryptoAlg-2420
Description of changes:
Add support for
OCSP_response_create
andOCSP_basic_add1_status
. As we've noted before, these functions are used as OCSP responder functions and Ruby happens to depend on them in their OCSP module.This builds upon the existing ASN.1 infrastructure we already have for creating OCSP structures. The two APIs allow for the user to specify relevant fields while creating the OCSP structures.
Call-outs:
New error codes were introduced, 1 from OpenSSL (
OCSP_R_NO_REVOKED_TIME
) and 1 new code that is used when an invalid field value is used (OCSP_R_UNKNOWN_FIELD_VALUE
).Testing:
New tests for both function
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.