-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EC_GROUP mutablility to custom curves #1881
Merged
samuel40791765
merged 5 commits into
aws:main
from
samuel40791765:ec-conversion-custom-4
Oct 14, 2024
Merged
Add EC_GROUP mutablility to custom curves #1881
samuel40791765
merged 5 commits into
aws:main
from
samuel40791765:ec-conversion-custom-4
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel40791765
force-pushed
the
ec-conversion-custom-4
branch
from
September 26, 2024 00:55
3e9cf48
to
e63eb00
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1881 +/- ##
==========================================
+ Coverage 78.49% 78.51% +0.02%
==========================================
Files 585 585
Lines 99630 99712 +82
Branches 14254 14262 +8
==========================================
+ Hits 78206 78291 +85
+ Misses 20789 20786 -3
Partials 635 635 ☔ View full report in Codecov by Sentry. |
samuel40791765
force-pushed
the
ec-conversion-custom-4
branch
from
October 4, 2024 18:28
f20c2df
to
0e72ec8
Compare
samuel40791765
force-pushed
the
ec-conversion-custom-4
branch
from
October 4, 2024 18:31
0e72ec8
to
2225f87
Compare
dkostic
reviewed
Oct 7, 2024
dkostic
reviewed
Oct 7, 2024
dkostic
reviewed
Oct 8, 2024
dkostic
approved these changes
Oct 9, 2024
WillChilds-Klein
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves
CryptoAlg-2547
Description of changes:
Following up on #1860 which introduces an API to return a mutable
EC_GROUP
, this commit applies the same concept for custom curves. Custom curves are already dynamically allocated, but were logically immutable due to the strict enforcement of callingEC_GROUP_new_curve_GFp
->EC_GROUP_set_generator
.The reference call in
EC_GROUP
that was used for custom curves is no longer needed. We actually duplicate the structure instead.Call-outs:
N/A
Testing:
Test using a custom generator identical to P-256.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.