ML-KEM FIPS 203 destruction of intermediate values #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1883 +/- ##
==========================================
- Coverage 78.50% 78.49% -0.02%
==========================================
Files 585 585
Lines 99516 99543 +27
Branches 14244 14242 -2
==========================================
+ Hits 78122 78133 +11
- Misses 20759 20777 +18
+ Partials 635 633 -2 ☔ View full report in Codecov by Sentry. |
andrewhop
reviewed
Sep 26, 2024
| @@ -190,6 +190,9 @@ void gen_matrix(ml_kem_params *params, polyvec *a, const uint8_t seed[KYBER_SYMB | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // FIPS 203. Section 3.3 Destruction of intermidiate values. | |||
| OPENSSL_memset(buf, 0, sizeof(buf)); | |||
There was a problem hiding this comment.
Should these all be OPENSSL_cleanse to make sure the compiler doesn't optimize out the unused 0 value?
jvdsn
reviewed
Sep 27, 2024
dkostic
force-pushed
the
ml-kem-destruct-intermidiate-values
branch
from
4cd79ef
to
4ebc30d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
CryptoAlg-2616
Description of changes:
FIPS 203 Section 3.3 requires destruction of intermediate values.
AWS-LC ML-KEM implementation allocates intermediate values
only on stack, so this destruction seems a bit silly, but we do it
anyway for compliance.
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.