Commits on Oct 21, 2024

1. Use illegal_parameter instead of decode_error for invalid key shares …

   This is extremely silly and a huge waste of everyone's time (I deeply
   regret disambiguating illegal_parameter and decode_error for RFC 8446),
   but so it goes. Technically these errors pass the TLS syntax and are an
   invalid value, so they should be illegal_parameter.
   
      Note: TLS defines two generic alerts (see Section 6) to use upon
      failure to parse a message.  Peers which receive a message which
      cannot be parsed according to the syntax (e.g., have a length
      extending beyond the message boundary or contain an out-of-range
      length) MUST terminate the connection with a "decode_error" alert.
      Peers which receive a message which is syntactically correct but
      semantically invalid (e.g., a DHE share of p - 1, or an invalid enum)
      MUST terminate the connection with an "illegal_parameter" alert.
   
   Update-Note: The error sent on invalid key share is now more correct.
   This does not change which connections do or do not fail, only which of
   two practically identical alert codes is sent to the other side.
   
   Change-Id: If0ddf511d6cf23383c6134ad30e3ae080c4f2769
   Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/71627
   Auto-Submit: David Benjamin <davidben@google.com>
   Reviewed-by: Bob Beck <bbe@google.com>
   Commit-Queue: Bob Beck <bbe@google.com>

   

   davidben authored and justsmth committed Oct 21, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for a643953
   • Browse repository at this point

   Copy the full SHA

   a643953 View commit details

   Browse the repository at this point in the history