-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Trim some redundant Arm feature detection files" #1979
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1979 +/- ##
==========================================
+ Coverage 78.86% 78.87% +0.01%
==========================================
Files 593 593
Lines 101933 101933
Branches 14450 14451 +1
==========================================
+ Hits 80386 80400 +14
+ Misses 20903 20890 -13
+ Partials 644 643 -1 ☔ View full report in Codecov by Sentry. |
This reverts commit d36bf85.
38d3bf3
to
95dd241
Compare
44dd4fb
to
a1ce804
Compare
a1ce804
to
372d9a2
Compare
While here, rotate the OpenBSD versions to keep up with the latest release (OpenBSD support model is N and N-1).
There's no tag which supports OpenBSD 7.6, so pinning to the latest commit for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like d36bf85 removed cpu_aarch64_openbsd.c
that handles the 64-bit stuff. While it should have removed cpu_arm_openbsd.c
that handles the 32-bit stuff, except this file doesn't exist in AWS-LC (a difference from BoringSSL).
Now see CryptoAlg-2781
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, looks like there are some test setup to work through before PR is ready to merge.
But the revert part lgtm.
This reverts commit d36bf85.
Issues:
Resolves AWS-LC-496
Description of changes:
d36bf85 was a merge from upstream. BoringSSL removed some 32-bit ARM stuff for OpenBSD, but the merge to aws-lc removed some aarch64 stuff, breaking the build on OpenBSD/arm64 platform (a regression from #962).
Testing:
I can successfully build aws-lc on OpenBSD/arm64 with this PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.