Cleanup test File utilities #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1989 +/- ##
==========================================
+ Coverage 78.86% 78.88% +0.02%
==========================================
Files 593 593
Lines 101934 101935 +1
Branches 14450 14450
==========================================
+ Hits 80386 80408 +22
+ Misses 20904 20881 -23
- Partials 644 646 +2 ☔ View full report in Codecov by Sentry. |
justsmth
force-pushed
the
cleanup-file-util
branch
from
721c497
to
d70832d
Compare
andrewhop
approved these changes
Nov 13, 2024
smittals2
reviewed
Nov 13, 2024
| @@ -122,7 +122,9 @@ bool TemporaryFile::Init(bssl::Span<const uint8_t> content) { | |||
| #else | |||
| std::string path = temp_dir + "bssl_tmp_file.XXXXXX"; | |||
| // TODO(davidben): Use |path.data()| when we require C++17. | |||
| mode_t prev_umask = umask(S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH); | |||
There was a problem hiding this comment.
Where did this mask come from?
There was a problem hiding this comment.
This particular just ensures that Read/Write permissions for "group" and "others" will not be granted when the file is created. (Typically, created files allow others to read.) https://man7.org/linux/man-pages/man2/umask.2.html
smittals2
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses: P168988559
Description of changes:
TemporaryFileandScopedFD.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.