Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EC] Unify scalar_mul_base point for ec_nistp curves #2003

Merged
merged 7 commits into from
Nov 22, 2024

Conversation

dkostic
Copy link
Contributor

@dkostic dkostic commented Nov 19, 2024

Issues:

CryptoAlg-2544

Description of changes:

Added unified scalar multiplication of the base point for curves
implemented in ec_nistp. This is a refactor of the algorithm in
p384.c and p521.c that makes it generic. The implementation
in p384.c and p521.c is substituted with this new unified
implementation.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@dkostic dkostic requested a review from a team as a code owner November 19, 2024 21:31
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.88%. Comparing base (ab8953b) to head (7ce5951).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2003      +/-   ##
==========================================
- Coverage   78.89%   78.88%   -0.01%     
==========================================
  Files         595      595              
  Lines      102451   102432      -19     
  Branches    14527    14519       -8     
==========================================
- Hits        80827    80804      -23     
  Misses      20976    20976              
- Partials      648      652       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@dkostic dkostic changed the title [EC] Unify scalar multiplication of the base point for ec_nistp curves [EC] Unify scalar_mul_base point for ec_nistp curves Nov 20, 2024
crypto/fipsmodule/ec/ec_nistp.c Outdated Show resolved Hide resolved
crypto/fipsmodule/ec/ec_nistp.c Outdated Show resolved Hide resolved
crypto/fipsmodule/ec/ec_nistp.c Outdated Show resolved Hide resolved
crypto/fipsmodule/ec/ec_nistp.c Outdated Show resolved Hide resolved
dkostic and others added 3 commits November 21, 2024 14:17
Co-authored-by: Nevine Ebeid <66388554+nebeid@users.noreply.github.com>
Co-authored-by: Nevine Ebeid <66388554+nebeid@users.noreply.github.com>
@dkostic dkostic enabled auto-merge (squash) November 21, 2024 23:48
crypto/fipsmodule/ec/p521.c Show resolved Hide resolved
crypto/fipsmodule/ec/ec_nistp.c Show resolved Hide resolved
crypto/fipsmodule/ec/ec_nistp.c Show resolved Hide resolved
@dkostic dkostic merged commit 80f984e into aws:main Nov 22, 2024
113 of 117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants