Add blowfish names to EVP_CIPHER API #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for the blowfish cipher was [added][1] a few years ago, but was is not addressed in `EVP_get_cipherbyname`. This commit adds that support and some testing. [1]: aws@6effbf2
justsmth
approved these changes
Dec 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2041 +/- ##
==========================================
+ Coverage 78.62% 78.69% +0.07%
==========================================
Files 596 598 +2
Lines 103012 103383 +371
Branches 14661 14691 +30
==========================================
+ Hits 80989 81357 +368
+ Misses 21373 21371 -2
- Partials 650 655 +5 ☔ View full report in Codecov by Sentry. |
samuel40791765
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Support for the blowfish cipher was added a few years ago, but was is not addressed in
EVP_get_cipherbyname. This commit adds that support and some testing.Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.