-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ILoggingBuilder #75
Comments
Hi @Kralizek, thank you for the suggestion. We'll evaluate adding this. |
For those like me looking for a workaround, here it is: logging.AddProvider(new AWSLoggerProvider(context.Configuration.GetAWSLoggingConfigSection())); |
The way the Microsoft logging infrastructure handles configuration is also a bit different, there's a lot of conventions there, e.g. everything being in the root "Logging" section, with provider-specific configuration being routed in based on the alias. I think filtering might also happen in the logging infrastructure, so specific providers don't necessarily need to reimplement filtering by log level. Microsoft's loggers are all under https://github.com/aspnet/Extensions/tree/master/src/Logging so the source there can be really useful. |
I have created PR #90 to add support for ILoggingBuilder |
Closing as this has shipped with the latest version. |
Microsoft is discoraging using
ILoggerFactory
in favor ofILoggingBuilder
.It would be great if we could get a variation of
AddAWSProvider
that accepts aILoggingBuilder
instead ofILoggerFactory
as first parameter.The text was updated successfully, but these errors were encountered: