-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh AWS.Logger.AspNetCore #90
Conversation
… not found in the Logging section then fallback to the legacy AWS.Logging section
…uration information from the IConfiguration added to the service collection.
…AspNetCore and add support for ISupportExternalScope
Oh wow! I love this PR! Thanks @normj |
@@ -24,7 +24,7 @@ public void MakeSureCanCreateScope() | |||
} | |||
|
|||
Assert.Single(coreLogger.ReceivedMessages); | |||
Assert.True(coreLogger.ReceivedMessages.Contains("[Information] MakeSureCanCreateScope: log \r\n"), "Messages don't contain actual log message."); | |||
Assert.True(coreLogger.ReceivedMessages.Contains("[Information] MakeSureCanCreateScope: log\r\n"), "Messages don't contain actual log message."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests will fail if run on a platform where Environment.NewLine
is not \r\n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated tests to use Environment.NewLine
constant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved when changing the NewLine handling in tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anticipating test changes for newlines. Approval given in understanding.
Issue #, if available:
#45
#50
#52
#76
Also migrate the PR from Amazon.Lambda.Logging.AspNetCore
aws/aws-lambda-dotnet#471
Description of changes:
This a refresh of AWS.Logger.AspNetCore pulling in some work that has been done to Amazon.Lambda.Logging.AspNetCore and migrate the library to the newer interfaces of ASP.NET Core 2.1
List of feature updates:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.