Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed issues with test suite instability #290

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

philasmar
Copy link
Contributor

Description of changes:
The tests in the release pipeline have been consistently failing due to stability issues. The tests interfere with each other and are not properly set up to run in parallel. Given that the test projects target multiple frameworks, the test runs affect each other even if tests within a certain class run sequentially. This PR applies multiple fixes to the tests to ensure a stable and consistent run.

  • Updated log group names to contain unique elements. This was the main issue since several tests publish to a log group with the same name. This affected event count assertions and test cleanup.
  • Updated function calls to use async/await
  • Updated certain threading calls to more recent versions of those calls. Task.Factory.StartNew -> Task.Run, Thread.Sleep -> Task.Delay, etc ...

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@philasmar philasmar added the Release Not Needed Add this label if a PR does not need to be released. label Dec 14, 2024
@philasmar philasmar merged commit 5b636ff into dev Dec 16, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Not Needed Add this label if a PR does not need to be released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants