Secrets Manager Proxy

[yanw-bq]

Review Status

• This is ready for review
• This is complete

Summary

Implement Secrets Manager Proxy

Description

• Introduce SECRETS_MANAGER_PROXY
• Unit Tests

Additional Reviewers

@justing-bq @sergiyvamz

[justing-bq]

I'm not a fan of overriding the real_connect and real_connect_dns_srv in this way.
Instead can we do the same approach as my PR where we define

bool CONNECTION_PROXY::connect(const char* host, const char* user, const char* password,
    const char* database, unsigned int port, const char* socket, unsigned long flags) {

    if (ds->enable_dns_srv) {
        return this->real_connect_dns_srv(host, user, password, database, flags);
    }

    return this->real_connect(host, user, password, database, port, socket, flags);
}

And then move all of this secrets manager connect logic to

bool SECRETS_MANAGER_PROXY::connect(const char* host, const char* user, const char* password,
	const char* database, unsigned int port, const char* socket, unsigned long flags)

And in here we can call next_proxy->connect() instead of next_proxy->real_connect().

Look at my PR for reference.

[justing-bq]

In general I would prefer to see the actual type rather than the auto keyword (unless the type is super unwieldy)

[justing-bq]

Likewise. Another benefit of my earlier suggestion is that we won't need to repeat all this logic again.

[justing-bq]

I'm not really familiar with this if (A; B) notation. Similar to a for loop, I'm guessing the first part is just initialization while the second part is the actual if condition? If so, can we move the const auto search = secrets_cache.find(this->secret_key); to above the if statement? I think it's more clear that way.

[justing-bq]

Where does this exception get caught and handled?

[justing-bq]

Likewise. Where does this exception get caught?

[justing-bq]

With a class this small I'm fine with just defining the entire class in a header file rather than splitting into a .h and .cc.

[justing-bq]

Have you tested this error?

Doing this works in the connect() logic but I'm less sure of the constructor logic.