feat: adfs authentication support #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
force-pushed
the
feat/adfs
branch
2 times, most recently
from
e142ac1
to
acab5c7
Compare
karenc-bq
force-pushed
the
feat/adfs
branch
from
acab5c7
to
e11669d
Compare
jkwuc89
reviewed
Sep 11, 2024
jkwuc89
reviewed
Sep 11, 2024
jkwuc89
reviewed
Sep 11, 2024
| std::string ADFS_SAML_UTIL::get_value_by_key(const std::string& input, const std::string& key) { | ||
| std::string pattern("("); | ||
| pattern += key; | ||
| pattern += ")\\s*=\\s*\"(.*?)\""; |
There was a problem hiding this comment.
Minor: std::regex pattern on line 129 above is using a const for the pattern. Does it make sense to define a const for this pattern as well?
jkwuc89
reviewed
Sep 11, 2024
jkwuc89
reviewed
Sep 11, 2024
jkwuc89
reviewed
Sep 11, 2024
jkwuc89
approved these changes
Sep 11, 2024
ColinKYuen
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add ADFS authentication support.
Update the build-installer script so it has all required dependencies to build the driver.
Description
Review Status
Additional Reviewers