fix: Add feature flag to unblock new deployments #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariemary-amz
approved these changes
Nov 5, 2024
rondeau-aws
approved these changes
Nov 5, 2024
Added the feature flag: @aws-cdk/aws-autoscaling:generateLaunchTemplateInsteadOfLaunchConfig to all example RFDK applications, as well as the integration tests. This allows deployments in fresh accounts to succeed since Launch Configurations are deprecated. Signed-off-by: Caden Marofke <132690522+marofke@users.noreply.github.com>
marofke
force-pushed
the
marofke/launch-config-feature-flag
branch
from
cef91c5 to
765f36a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Deployments of RFDK to brand new accounts would fail with:
This is because Launch Configurations were deprecated, and recently denied for new accounts in aws/aws-cdk#25910
Solution
Added the feature flag that converts launch configurations to launch templates, as described in the documentation: https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md#aws-cdkaws-autoscalinggeneratelaunchtemplateinsteadoflaunchconfig
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license