feat(core): update to work with Deadline 10.4.0 #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marofke
reviewed
Nov 22, 2024
marofke
previously approved these changes
Nov 25, 2024
rondeau-aws
force-pushed
the
update-deadline-10.4.0
branch
from
9291437 to
475019d
Compare
marofke
approved these changes
Nov 25, 2024
rondeau-aws
removed
the
pr/do-not-merge
ariemary-amz
approved these changes
Nov 26, 2024
rondeau-aws
force-pushed
the
update-deadline-10.4.0
branch
from
475019d to
29470e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to use the new Deadline 10.4.0 release with the RFDK.
Most of the issues we encountered are related to OS support in Deadline. Previously we installed Deadline on Amazon Linux 2, but this is no longer supported in Deadline 10.4.0.
Solution
WF-submit-jobs-to-sets.shscripts in our integration tests submitted jobs that run/usr/bin/sleep. This command is not available on Windows, causing occasional test failures. We changed the tests to runtimeout.exeon Windows instead.Testing
I ran the integration tests with Deadline 10.4.0.10 and confirmed that they succeed.
I also ran the integration tests on an older revision of this change, and confirmed that they succeeded with Deadline 10.3.2.1.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license