fix(deadline): fix import and HTTPS redirect errors in stage-deadline

[jusiskin]

Fixes #177

Problem

There are two issues with the stage-deadline script in RFDK 0.18.0 (see #177):

1. Failed import of aws-sdk

The stage-deadline.ts file imported some code from the shared lambda directory:

aws-rfdk/packages/aws-rfdk/bin/stage-deadline.ts

Line 15 in 90c83a4

import {IUris, Platform, Product, VersionProvider } from '../lib/core/lambdas/nodejs/version-provider';

This then imports from handler.ts:

aws-rfdk/packages/aws-rfdk/lib/core/lambdas/nodejs/version-provider/index.ts

Line 6 in 90c83a4

export * from './handler';

Which imports from custom-resource.ts:

aws-rfdk/packages/aws-rfdk/lib/core/lambdas/nodejs/version-provider/handler.ts

Line 9 in 90c83a4

import { CfnRequestEvent, SimpleCustomResource } from '../lib/custom-resource';

Which imports from dynamo-backed-resource.ts:

aws-rfdk/packages/aws-rfdk/lib/core/lambdas/nodejs/lib/custom-resource/index.ts

Line 6 in 90c83a4

export * from './dynamo-backed-resource';

Which imports the aws-sdk:

aws-rfdk/packages/aws-rfdk/lib/core/lambdas/nodejs/lib/custom-resource/dynamo-backed-resource.ts

Line 9 in 90c83a4

import { DynamoDB } from 'aws-sdk';

This causes an import error when running the command through npx since we do not specify aws-sdk in the list of dependencies for the aws-rfdk package that contains stage-deadline.

2. HTTP 301 Redirect from HTTP -> HTTPS causes abort

The VersionProvider class uses Node.JS's built-in http module to fetch the download index.

aws-rfdk/packages/aws-rfdk/lib/core/lambdas/nodejs/version-provider/version-provider.ts

Line 157 in 90c83a4

http.get(options, (res: http.IncomingMessage) => {

But, the download index is an HTTPS URL:

aws-rfdk/packages/aws-rfdk/lib/core/lambdas/nodejs/version-provider/version-provider.ts

Line 147 in 90c83a4

const productionInfoURL = 'https://downloads.thinkboxsoftware.com/version_info.json';

The http module appears to accept the https:// URL, but makes a plain-HTTP request. The response comes back as an HTTP 301 redirect. The VersionProvider handles this as an error:

aws-rfdk/packages/aws-rfdk/lib/core/lambdas/nodejs/version-provider/version-provider.ts

Lines 167 to 177 in 90c83a4

	if (res.statusCode === 200) {
	try {
	// convert the response to a json object and return.
	const data = JSON.parse(json);
	resolve(data);
	} catch (e) {
	reject(e);
	}
	} else {
	reject(new Error(`Expected status code 200, but got ${res.statusCode}`));
	}

Solution

Create a 0.18.1 patch release of RFDK that resolves the two bugs mentioned above. Each of the fix is addressed in their own commit. Summary of the changes:

1. Failed import of aws-sdk

Import the symbols directly from packages/aws-rfdk/lib/core/lambdas/nodejs/version-provider/version-provider' to avoid the import of aws-sdk`.

2. HTTP 301 Redirect from HTTP -> HTTPS causes abort

Replaced the usage of http module with https.

Patch release

Created a bump commit that increments the patch version. Also note that this pull request targets the releases/0.18.1 branch. Once this is merged, a release pipeline will be ran against this branch.

Follow-up PR(s) will be created to merge the fixing commits back to the mainline branch.

Testing

Reproduce issue using a dev build

1. Created a new CDK application in a separate directory:

    npx cdk@1.66.0 init --language typescript

2. Link the dev build using the link-all.sh script

   ${PATH_TO_RFDK_CHECKOUT}/link-all.sh

3. Rename the aws-sdk directory in ${PATH_TO_RFDK_CHECKOUT}/node_modules to aws-sdk2

4. Attempt to stage Deadline:

   npx stage-deadline

5. Confirmed I get the reproduced error message:

   Cannot find module 'aws-sdk'
   

After fixing confirm the errors are gone and Deadline is staged

1. Same process as above after applying the fix to my changes to my RFDK development build

2. Confirmed no errors and Deadline is staged:

   $ tree stage
   stage
   ├── bin
   │   └── DeadlineClient-10.1.10.6-linux-x64-installer.run
   ├── deadline_docker
   ├── dlconfig
   │   ├── client-rq-connection
   │   ├── dlconfig
   │   ├── fetch_file
   │   ├── fetch_secret
   │   └── json-query
   ├── dldocker
   │   ├── commands.py
   │   ├── docker.py
   │   ├── formatters.py
   │   ├── __init__.py
   │   ├── __main__.py
   │   ├── manifest.py
   │   └── recipe.py
   ├── Dockerfile
   ├── LICENSE
   ├── license-forwarder
   │   ├── README.md
   │   └── root
   │       ├── app
   │       │   └── configure-license-forwarder.sh
   │       └── dlconfig
   │           ├── ubl-certificates
   │           ├── ubl-limits
   │           └── ubl_limits.py
   ├── manifest.json
   ├── NOTICE
   ├── rcs
   │   ├── README.md
   │   └── root
   │       ├── app
   │       │   └── configure-rcs.sh
   │       └── dlconfig
   │           ├── database-credentials
   │           ├── direct-repo-connection
   │           └── rcs-tls
   └── README.md
   
   11 directories, 29 files

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[jusiskin]

Heads up: when merging, please don't squash the commits, since they are already written using conventional commits and one includes the bump commit that needs to be separate for our release automation.