fix(deadline): bad file path for Repository when using VersionQuery #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horsmand
approved these changes
Nov 25, 2020
There was a problem hiding this comment.
This looks fine to me, but I think we may want to re-evaluate if it makes sense to leave these VersionQuery fields like majorVersion as numbers when we need to jump through hoops any time we need to use them. It might make more sense to just make them strings.
jusiskin
approved these changes
Nov 26, 2020
jusiskin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #251
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license