fix(deadline): VersionQuery cross-stack issue #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The VersionQuery RFDK construct abuses the CloudFormation resource model.
When we are referencing the VersionQuery from another stack, the values in stack outputs are not allowed to change.
This becomes a problem when new version released and was not used specific version.
Solution
To solve this problem in short-term perspective we add a synthesis-time validation check to ensure consumers of a VersionQuery are in the same stack. This would mitigate the risk of customers using them cross-stack and guide them towards one VersionQuery instance per stack.
Testing
Were created unit tests and validated that error throwing when used VersionQuery from different stack.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license