chore(deps): bumping cdk from 1.116.0 to 1.129.0 #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jusiskin
added
dependencies
ddneilson
requested changes
Oct 21, 2021
There was a problem hiding this comment.
Looks like there's a whole pile of additional dependencies to sort through -- they added a bunch in the last 12 versions of CDK, or something, it seems.
From the CI:
aws-rfdk: $ cdk-build
aws-rfdk: warning JSII6: A "peerDependency" on "@aws-cdk/assets" at "1.128.0" means you should take a "devDependency" on "@aws-cdk/assets" at "1.128.0" (found "undefined")"
aws-rfdk: warning JSII6: A "peerDependency" on "@aws-cdk/aws-apigateway" at "1.128.0" means you should take a "devDependency" on "@aws-cdk/aws-apigateway" at "1.128.0" (found "undefined")"
aws-rfdk: warning JSII6: A "peerDependency" on "@aws-cdk/aws-apigatewayv2" at "1.128.0" means you should take a "devDependency" on "@aws-cdk/aws-apigatewayv2" at "1.128.0" (found "undefined")"
... and so on
examples/deadline/All-In-AWS-Infrastructure-Basic/ts/bin/app.ts
Outdated
Show resolved
Hide resolved
examples/deadline/All-In-AWS-Infrastructure-Basic/ts/bin/app.ts
Outdated
Show resolved
Hide resolved
examples/deadline/All-In-AWS-Infrastructure-Basic/ts/bin/config.ts
Outdated
Show resolved
Hide resolved
examples/deadline/All-In-AWS-Infrastructure-Basic/ts/lib/service-tier.ts
Outdated
Show resolved
Hide resolved
horsmand
force-pushed
the
release-0-38
branch
from
19b4cec
to
4746cea
Compare
|
I've removed my test code but am still looking into why all those |
jusiskin
requested changes
Oct 21, 2021
There was a problem hiding this comment.
Other than the feedback already brought up by @ddneilson, this looks good. Two small things with code suggestions here:
horsmand
force-pushed
the
release-0-38
branch
3 times, most recently
from
b5645e8
to
3f8c8de
Compare
horsmand
force-pushed
the
release-0-38
branch
from
3f8c8de
to
d351ddf
Compare
horsmand
changed the title
jusiskin
approved these changes
Oct 22, 2021
ddneilson
requested changes
Oct 22, 2021
Discussed off-line. We'll have to accept this warning. |
ddneilson
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded all our dependencies to prep for our next RFDK release.
Testing was done by running the build in the base directory along with all the typescript example directories, and deploying the basic example. I also upgraded JSII in our pipeline and deployed a test pipeline that ran against these changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license