Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support HttpApi URIs generated by the CDK #2438

Merged
merged 4 commits into from
Dec 4, 2020

Conversation

mgrandis
Copy link
Contributor

@mgrandis mgrandis commented Dec 2, 2020

Which issue(s) does this change fix?

#2346

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Checklist

  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mgrandis mgrandis marked this pull request as ready for review December 2, 2020 22:26
@mgrandis mgrandis linked an issue Dec 3, 2020 that may be closed by this pull request
@mgrandis mgrandis merged commit afc3dbd into aws:develop Dec 4, 2020
@mgrandis mgrandis deleted the function_arn_extract branch December 4, 2020 01:09
mndeveci pushed a commit to mndeveci/aws-sam-cli that referenced this pull request Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpApi created with CDK does not start
3 participants