fix: use container for the builds since some of the runtimes are not present in the Canary environment #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…present in the Canary environment
mndeveci
changed the title
moelasmar
approved these changes
Dec 15, 2020
This reverts commit 9951892
wchengru
approved these changes
Dec 15, 2020
elbayaaa
approved these changes
Dec 15, 2020
bramkoot
pushed a commit
to bramkoot/aws-sam-cli
that referenced
this pull request
Jan 15, 2021
…present in the Canary environment (aws#2480) * fix: use container for the builds since some of the runtimes are not present in the Canary environment * chore: bump version * Revert "chore: bump version" This reverts commit 9951892 * fix: don't run build on windows * Fix the warm containers integration test cases * black reformat * ci: check appveyor failures * Revert "ci: check appveyor failures" This reverts commit 5c0e57b * ci: edit windows condition * ci: edit windows condition * ci: check windows docker version * ci: Added Docker Hub Login for Windows (aws#2484) * ci: check which command run * Fix/windows docker login Env (aws#2485) * Added Docker Hub Login for Windows * Changed to Checking env Instead of variable * ci: fix windows tests * Revert "ci: fix windows tests" This reverts commit 0cccd4d * fix: run smoke tests in a temporary folder * fix: remove redundant print statement * chore: version bump Co-authored-by: Mohamed Elasmar <melasmar@amazon.com> Co-authored-by: Cosh_ <CoshUS@users.noreply.github.com>
mndeveci
added a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Jan 19, 2021
…present in the Canary environment (aws#2480) * fix: use container for the builds since some of the runtimes are not present in the Canary environment * chore: bump version * Revert "chore: bump version" This reverts commit 9951892 * fix: don't run build on windows * Fix the warm containers integration test cases * black reformat * ci: check appveyor failures * Revert "ci: check appveyor failures" This reverts commit 5c0e57b * ci: edit windows condition * ci: edit windows condition * ci: check windows docker version * ci: Added Docker Hub Login for Windows (aws#2484) * ci: check which command run * Fix/windows docker login Env (aws#2485) * Added Docker Hub Login for Windows * Changed to Checking env Instead of variable * ci: fix windows tests * Revert "ci: fix windows tests" This reverts commit 0cccd4d * fix: run smoke tests in a temporary folder * fix: remove redundant print statement * chore: version bump Co-authored-by: Mohamed Elasmar <melasmar@amazon.com> Co-authored-by: Cosh_ <CoshUS@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
For fixing canary failures.
Why is this change necessary?
Canary environments doesn't have all the build tools to build functions in-process.
How does it address the issue?
Builds some of the functions inside container.
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.