fix: Handle input parameters classified as multiple value click options #6108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mndeveci
reviewed
Oct 18, 2023
mndeveci
approved these changes
Oct 18, 2023
hnnasit
approved these changes
Oct 19, 2023
moelasmar
pushed a commit
to moelasmar/aws-sam-cli
that referenced
this pull request
Oct 22, 2023
…ns (aws#6108) * fix: Handle parsing input parameter from config * fix typo * Fix docstring * Add debug log stating that a value was changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#6053
Why is this change necessary?
Click will handle single values and convert them to a list before being processed if the option is set to
multiple=True. When using asamconfigfile, the values are injected into click after this conversion resulting in click crashing when these values are processed. This leads to a discrepancy in behaviour between command line options and configuration file options.How does it address the issue?
Check the configured resources in the
samconfigfile and ensure the same type of option processing is done to convert single value types to a list before giving them to click.What side effects does this change have?
N/A
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.