-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove 1 sec delay on invoke #6418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/local/start-api
sam local start-api command
area/local/invoke
sam local invoke command
area/local/start-invoke
labels
Dec 7, 2023
hawflau
reviewed
Dec 8, 2023
hawflau
reviewed
Dec 8, 2023
mndeveci
reviewed
Dec 8, 2023
mndeveci
approved these changes
Dec 8, 2023
hawflau
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/local/invoke
sam local invoke command
area/local/start-api
sam local start-api command
area/local/start-invoke
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#6173
Why is this change necessary?
Currently there is an explicit 1 second sleep in the code to work around a race condition and ensure that everything that is printed to the cli is done in the correct order.
The original race condition occurs when the main thread finishes its execution and prints the flask response to stdout, while there are still some things from the docker container that need to be printed.
This can be reproduced currently by the following steps (after removing the sleep in dev version of sam)
How does it address the issue?
using a threading.Event, that gets set only when the regex matches the pattern, to wait until it is safe to end the flask request
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.