Fix: sam invoke local throw error 'utf-8' codec can't decode byte 0xff #6559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/local/start-api
lucashuy
approved these changes
Jan 16, 2024
| @@ -7,6 +7,6 @@ Resources: | |||
| Type: AWS::Serverless::Function | |||
| Properties: | |||
| Handler: main.image_handler | |||
| Runtime: python3.12 | |||
| Runtime: python3.11 | |||
There was a problem hiding this comment.
Did we ever find a root cause for this?
There was a problem hiding this comment.
When we make the request to lambda it only ever returns a 502, provided the host machine is windows and the lambda is returning raw bytes. I assume that it's because a bug between docker and the python 3.12 runtime but I wasn't able to narrow it down further than that
There was a problem hiding this comment.
Could that be docker version limitation for these new (al2023 based) runtimes? Were you able to run the tests on a Windows machine with newer Docker version to see if these tests are passing or not?
mndeveci
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#6369
Why is this change necessary?
The code was previously refactored to use Strings to handle the IO related to sam local invoke and sam local start-lambda this fixed some issues where certain strings werent displayed correctly, but broke the functionality to support lambdas returning images
How does it address the issue?
adds an extra BytesIO object to the stream writer and checks if it was written to in order to determine if it should return strings or the bytes
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.