Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging for files pulled from S3 + enable RIE debug for flaky test #6604

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

bentvelj
Copy link
Contributor

Why is this change necessary?

Purposes of debugging the flaky golang test

tests/end_to_end/test_runtimes_e2e.py::TestHelloWorldZipPackagePermissionsEndToEnd_0_go1_x::test_hello_world_workflow

How does it address the issue?

Add logging for files pulled from S3, since this is a unique component of this test and there could be permission issues preventing the lambda from invoking properly.

Enable RIE debug environment variable to get more information

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bentvelj bentvelj requested a review from a team as a code owner January 25, 2024 22:27
@bentvelj bentvelj requested review from lucashuy, jysheng123, mndeveci and mildaniel and removed request for lucashuy and jysheng123 January 25, 2024 22:27
@bentvelj bentvelj added this pull request to the merge queue Jan 25, 2024
Merged via the queue into aws:develop with commit 5dedfbb Jan 26, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants