Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle imageuri not being string #7275

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix: handle imageuri not being string #7275

merged 1 commit into from
Jul 24, 2024

Conversation

sidhujus
Copy link
Contributor

Which issue(s) does this change fix?

#7270

Why is this change necessary?

Intrinsics do not resolve properly at this stage, and we added a workaround before but missed it in this case.
#7131

How does it address the issue?

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sidhujus sidhujus requested a review from a team as a code owner July 23, 2024 21:52
@github-actions github-actions bot added area/build sam build command pr/internal labels Jul 23, 2024
@sidhujus sidhujus added this pull request to the merge queue Jul 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 24, 2024
@sidhujus sidhujus added this pull request to the merge queue Jul 24, 2024
Merged via the queue into aws:develop with commit 7435911 Jul 24, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build sam build command pr/internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants