fix: change openssl url in build linux #7284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildaniel
approved these changes
Jul 26, 2024
lucashuy
reviewed
Jul 26, 2024
installer/pyinstaller/build-linux.sh
Outdated
| @@ -49,7 +49,7 @@ mkdir -p .build/output/openssl | |||
| cd .build/output/openssl | |||
|
|
|||
| echo "Building OpenSSL" | |||
| curl "https://www.openssl.org/source/openssl-${openssl_version}.tar.gz" --output openssl.tar.gz | |||
| curl -L "https://github.com:443/openssl/openssl/releases/download/OpenSSL_${openssl_version//./_}/openssl-${openssl_version}.tar.gz" --output openssl.tar.gz | |||
There was a problem hiding this comment.
We can probably remove the port here. Not that I'd imagine Github would open their webserver on anything other than port 443, but its not required.
hawflau
approved these changes
Jul 26, 2024
lucashuy
approved these changes
Jul 26, 2024
|
Btw we could have added this flag for other places as well. Like this one; https://github.com/aws/aws-sam-cli/blob/develop/installer/pyinstaller/build-linux.sh#L52 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
the url now redirects to github which redirects to the release artifact, this changes the url we use to be the one before the final redirect
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.