fix: Fix copying symlink files for Windows #7351
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#6943
Note: Adding an integration test seemed like an overkill for a small change. I've added unit tests to cover these, but lmk if you feel adding one is necessary.
Why is this change necessary?
When the shared (within same code_uri) node_module dependencies were copied over to the other Function, the symlink files were not being copied over. However, as mentioned in the docs, copy2 does not copy symlinks on all the platforms (Windows being 1 of them). This causes OsError to be thrown crashing the command.
How does it address the issue?
Catches the exception and handles it by calling
create_symlink_or_copy
function to either create a symlink or copy the target file directly.What side effects does this change have?
No side effects.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.