Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make behaviour clear about returning in finally block #7605

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

lucashuy
Copy link
Contributor

@lucashuy lucashuy commented Oct 24, 2024

Which issue(s) does this change fix?

#7599

Why is this change necessary?

Returning inside a finally block swallows any previously re-raised exceptions, and might raise up questions about it's usage.

How does it address the issue?

Adds a comment that explains it was deliberate.

What side effects does this change have?

None

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lucashuy lucashuy requested a review from a team as a code owner October 24, 2024 23:12
@hawflau hawflau added this pull request to the merge queue Oct 28, 2024
Merged via the queue into aws:develop with commit a0c0ede Oct 28, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants