Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: Remove unused shapes before processing model #275

Closed
jasdel opened this issue Mar 4, 2019 · 1 comment
Closed

codegen: Remove unused shapes before processing model #275

jasdel opened this issue Mar 4, 2019 · 1 comment
Labels
v1-sync

Comments

@jasdel
Copy link
Contributor

jasdel commented Mar 4, 2019

The v2 SDK should trim unused shapes prior to processing the model, ot prevent generated name classing with unused shapes.

V1 Issue: aws/aws-sdk-go#2358
@jasdel jasdel added the v1-sync label Mar 4, 2019
@jasdel jasdel mentioned this issue May 17, 2019
Merged
jasdel added a commit that referenced this issue May 24, 2019
@jasdel
Refactoring SDK's code generation patterns (#298)
e6b1343 
Updates the SDK's code generation pattern with several improvements to improve discoverability, and consistency in client naming.

* Standardizing of the service model's ServiceID for the name of the
service client's package.

* Adds an operation `Response` type that is in addition from the
operation's `Output` parameters. This prevents collisions between SDK
response metadata, marshaling methods, and modeled output parameters.

* Refactor service client package's client name to be named Client
instead of the service's short name. Removes the stuttering of client
package and type, (e.g. s3.S3 becomes s3.Client)

* Fix service endpoint lookups use the the service's modeled EndpointID
instead of inconsistent service name.

* Generate API operations into their own file instead of all operations
and parameter types being generated into a single file. This improves
readability of individual source files for documentation reference.
Non-input/output types are still generated into a single file. This change also fixes several occurrences of incorrectly generated API operation input/output type names.

* Removes aws/endpoints Service identifiers from endpoint list. These
were not actually service identifiers, but EndpointsID. In addition the
values modeled by the services were unstable, and could change causing
breaking changes in the SDK's aws/endpoints package. The service
client package's `EndpointsID` const should be used instead.

* Move Paginate method from the initialized Request type into its own
construct via the New<RequestType>Paginator function to create the
request paginator. (e.g. req.Paginate becomes NewListObjectsPaginator(req))

Fix #294 #282 #275
@jasdel
Copy link
Contributor Author

jasdel commented May 30, 2019 •
edited
Loading

Fixed in #298

@jasdel jasdel closed this as completed May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v1-sync
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasdel