s3manager Uploader returns URL encoded Location for bigger files (multipart upload) #323
Comments
jasdel
added a commit
to jasdel/aws-sdk-go-v2
that referenced
this issue
Jun 14, 2019
Updates the Location returned value of S3 Upload's Multipart UploadOutput type to be consistent with single part upload URL. This update also brings the multipart upload Location inline with the S3 object URLs created by the SDK. Fix aws#323 V2 Port aws/aws-sdk-go#2453
|
Thanks for reaching out to us on this issue. I've created #324 that fixes this issue in the V2 SDK. |
jasdel
added a commit
that referenced
this issue
Jun 14, 2019
Updates the Location returned value of S3 Upload's Multipart UploadOutput type to be consistent with single part upload URL. This update also brings the multipart upload Location inline with the S3 object URLs created by the SDK. Fix #323 V2 Port aws/aws-sdk-go#2453
jasdel
added a commit
to jasdel/aws-sdk-go-v2
that referenced
this issue
Jul 24, 2019
Services === * Synced the V2 SDK with latest AWS service API definitions. * Fixes [aws#341](aws#341) * Fixes [aws#342](aws#342) SDK Breaking Changes === * `aws`: Add default HTTP client instead of http.DefaultClient/Transport ([aws#315](aws#315)) * Adds a new BuildableHTTPClient type to the SDK's aws package. The type uses the builder pattern with immutable changes. Modifications to the buildable client create copies of the client. Adds a HTTPClient interface to the aws package that the SDK will use as an abstraction over the specific HTTP client implementation. The SDK will default to the BuildableHTTPClient, but a *http.Client can be also provided for custom configuration. When the SDK's aws.Config.HTTPClient value is a BuildableHTTPClient the SDK will be able to use API client specific request timeout options. * Fixes [aws#279](aws#279) * Fixes [aws#269](aws#269) SDK Enhancements === * `service/s3/s3manager`: Update S3 Upload Multipart location ([aws#324](aws#324)) * Updates the Location returned value of S3 Upload's Multipart UploadOutput type to be consistent with single part upload URL. This update also brings the multipart upload Location inline with the S3 object URLs created by the SDK. * Fixes [aws#323](aws#323) * V2 Port [aws/aws-sdk-go#2453](aws/aws-sdk-go#2453) SDK Bugs === * `private/model`: Handles empty map vs unset map behavior in send request ([aws#337](aws#337)) * Updated shape marshal model to handle the empty map vs nil map behavior. Adding a test case to assert behavior when a user sends an empty map vs nil map. * Fix [aws#332](aws#332) * `service/rds`: Fix presign URL for same region ([aws#331](aws#331)) * Fixes RDS no-autopresign URL for same region issue for aws-sdk-go-v2. Solves the issue by making sure that the presigned URLs are not created, when the source and destination regions are the same. Added and updated the tests accordingly. * Fix [aws#271](aws#271) * `private/protocola/json/jsonutil`: Fix Unmarshal map[string]bool ([aws#320](aws#320)) * Fixes the JSON unmarshaling of maps of bools. The unmarshal case was missing the condition for bool value, in addition the bool pointer. * Fix [aws#319](aws#319)
jasdel
added a commit
that referenced
this issue
Jul 25, 2019
Services === * Synced the V2 SDK with latest AWS service API definitions. * Fixes [#341](#341) * Fixes [#342](#342) SDK Breaking Changes === * `aws`: Add default HTTP client instead of http.DefaultClient/Transport ([#315](#315)) * Adds a new BuildableHTTPClient type to the SDK's aws package. The type uses the builder pattern with immutable changes. Modifications to the buildable client create copies of the client. Adds a HTTPClient interface to the aws package that the SDK will use as an abstraction over the specific HTTP client implementation. The SDK will default to the BuildableHTTPClient, but a *http.Client can be also provided for custom configuration. When the SDK's aws.Config.HTTPClient value is a BuildableHTTPClient the SDK will be able to use API client specific request timeout options. * Fixes [#279](#279) * Fixes [#269](#269) SDK Enhancements === * `service/s3/s3manager`: Update S3 Upload Multipart location ([#324](#324)) * Updates the Location returned value of S3 Upload's Multipart UploadOutput type to be consistent with single part upload URL. This update also brings the multipart upload Location inline with the S3 object URLs created by the SDK. * Fixes [#323](#323) * V2 Port [aws/aws-sdk-go#2453](aws/aws-sdk-go#2453) SDK Bugs === * `private/model`: Handles empty map vs unset map behavior in send request ([#337](#337)) * Updated shape marshal model to handle the empty map vs nil map behavior. Adding a test case to assert behavior when a user sends an empty map vs nil map. * Fix [#332](#332) * `service/rds`: Fix presign URL for same region ([#331](#331)) * Fixes RDS no-autopresign URL for same region issue for aws-sdk-go-v2. Solves the issue by making sure that the presigned URLs are not created, when the source and destination regions are the same. Added and updated the tests accordingly. * Fix [#271](#271) * `private/protocola/json/jsonutil`: Fix Unmarshal map[string]bool ([#320](#320)) * Fixes the JSON unmarshaling of maps of bools. The unmarshal case was missing the condition for bool value, in addition the bool pointer. * Fix [#319](#319)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please fill out the sections below to help us address your issue.
Version of AWS SDK for Go?
2.0.0-preview.5
Version of Go (
go version)?go1.12.3 darwin/amd64
What issue did you see?
multipart uploader returns encoded url. This has been fixed in aws-sdk-go but not aws-sdk-go-v2 (aws/aws-sdk-go#1385). Could you please apply the fix to aws-sdk-go-v2 as well. Thanks!
Steps to reproduce
If you have have an runnable example, please include it.
The text was updated successfully, but these errors were encountered: