Fix xml attribute serialization #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw this is still failing because the updated go hash is still not getting picked up |
|
need to address using an enum, which isn't currently handled |
JordonPhillips
force-pushed
the
xml-attr-ser-fix
branch
from
76a3c42 to
4da4af5
Compare
|
Turns out the test jasdel submitted was off, there's a pr to fix it: smithy-lang/smithy#694 |
JordonPhillips
force-pushed
the
xml-attr-ser-fix
branch
from
4da4af5 to
8780d0e
Compare
This fixes an issue where xml attributes were not being serialized except at the root level.
JordonPhillips
force-pushed
the
xml-attr-ser-fix
branch
from
8780d0e to
f12d963
Compare
jasdel
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where xml attributes were not being serialized except at the root level.