-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Single Sign-On (SSO) Provider Support #1072
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
reviewed
Jan 23, 2021
skmcgrail
force-pushed
the
ssoProvider
branch
from
January 25, 2021 18:01
17d5daa
to
25b76b0
Compare
jasdel
suggested changes
Jan 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good couple suggestions, mainly with gofmt/go lint.
skmcgrail
force-pushed
the
ssoProvider
branch
2 times, most recently
from
January 25, 2021 21:55
5bfa8d7
to
b11d9bc
Compare
skmcgrail
force-pushed
the
ssoProvider
branch
from
January 25, 2021 22:33
b11d9bc
to
2502e5d
Compare
skmcgrail
force-pushed
the
ssoProvider
branch
from
January 25, 2021 23:39
2502e5d
to
4932dc5
Compare
skotambkar
reviewed
Jan 25, 2021
skotambkar
approved these changes
Jan 25, 2021
jasdel
approved these changes
Jan 25, 2021
skmcgrail
force-pushed
the
ssoProvider
branch
from
January 26, 2021 18:32
914ddf2
to
52e5565
Compare
skotambkar
reviewed
Jan 26, 2021
skmcgrail
force-pushed
the
ssoProvider
branch
from
January 26, 2021 21:34
52e5565
to
fe60421
Compare
skotambkar
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
jasdel
approved these changes
Jan 26, 2021
skmcgrail
force-pushed
the
ssoProvider
branch
6 times, most recently
from
January 27, 2021 00:39
68b819c
to
670cd99
Compare
skmcgrail
force-pushed
the
ssoProvider
branch
from
January 27, 2021 02:00
670cd99
to
92a8d37
Compare
This was referenced Mar 15, 2021
Merged
Bump github.com/aws/aws-sdk-go-v2/config from 1.1.1 to 1.1.2 in /backend
WinWisely268/glasspolish#21
Merged
Merged
Closed
Merged
Merged
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the AWS Single Sign-On (SSO) service by supporting the ability to utilize tokens cached in
~/.aws/sso/cache
.Adds support for the AWS SSO provider in the default credential loading chain.