Fix SSO Validation of Incomplete Profiles #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
skmcgrail
commented
Feb 2, 2021
skmcgrail
commented
- Ports the fix from V1 #3769 around SSO profile validation
- Fixes an uncovered bug where environment credentials were not correctly taking precedence over profile credentials
skmcgrail
requested review from
jasdel and
skotambkar
and removed request for
jasdel
skmcgrail
force-pushed
the
ssoValidation
branch
from
db823f4
to
4dbfa3b
Compare
jasdel
approved these changes
Feb 3, 2021
skotambkar
approved these changes
Feb 3, 2021
This was referenced Mar 15, 2021
Bump github.com/aws/aws-sdk-go-v2/config from 1.1.1 to 1.1.2
giantswarm/aws-ebs-csi-volume-limiter#8
Merged
Closed
build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.1.1 to 1.1.2
fsouza/s3-upload-proxy#157
Merged
Merged
Merged
Closed
Merged
This was referenced Mar 15, 2021
Bump github.com/aws/aws-sdk-go-v2/config from 1.1.1 to 1.1.2 in /backend
WinWisely268/glasspolish#21
Merged
Merged
Closed
Merged
Merged
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.