Do not Escape HTML when encoding the policy #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @joshwoodkx for bringing this to our attention, and putting together a PR to address this issue. This seems to have been an oversight when porting over the code from V1. It appears that the logic was not copied from https://github.com/aws/aws-sdk-go/blob/e2d6cb448883e4f4fcc5246650f89bde349041ec/service/cloudfront/sign/policy_json_1_7.go as expected. We will get this merged in for our next release. |
skmcgrail
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1373
This code was taken from a related PR on the V1 SDK: aws/aws-sdk-go#2164.
Since the V2 SDK only supports go1.15 and above, we can just use the
encoder.SetEscapeHTML(false)that the go json encoder provides (the PR for V1 had to also support v1.7, so that PR also had to implement a solution without using this)