aws/defaults: Fix request metadata headers causing signature errors #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
skmcgrail
approved these changes
Apr 21, 2020
skotambkar
approved these changes
Apr 21, 2020
skmcgrail
approved these changes
Apr 21, 2020
Fixes the SDK's adding the request metadata headers in the wrong location within the request handler stack. This created a situation where a request that was retried would sign the new attempt using the old value of the header. The header value would then be changed before sending the request. This moves the request invocation id to only occur during build, maintaining its value across all requests attempts. Also moves request retry metadata header to be before sign, and after build. This ensures that a new value for each attempt can be set, and included in each request attempt. Fix aws#533 Fix aws#521
jasdel
force-pushed
the
fixup/InvalidSignature
branch
from
cad4f17
to
9379ff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the SDK's adding the request metadata headers in the wrong location within the request handler stack. This created a situation where a request that was retried would sign the new attempt using the old value of the header. The header value would then be changed before sending the request.
This moves the request invocation id to only occur during build, maintaining its value across all requests attempts. Also moves request retry metadata header to be before sign, and after build. This ensures that a new value for each attempt can be set, and included in each request attempt.
Fix #533
Fix #521