Add support for json rpc protocol serde #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
reviewed
Jun 20, 2020
...go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonRpcProtocolGenerator.java
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
jsonrpc10
branch
5 times, most recently
from
378ab24 to
8492ad5
Compare
jasdel
reviewed
Jun 29, 2020
...go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonRpcProtocolGenerator.java
Outdated
Show resolved
Hide resolved
jasdel
reviewed
Jun 29, 2020
...-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonShapeSerVisitor.java
Show resolved
Hide resolved
jasdel
reviewed
Jun 29, 2020
JordonPhillips
changed the title
jasdel
reviewed
Jul 7, 2020
...thy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AwsProtocolUtils.java
Show resolved
Hide resolved
jasdel
reviewed
Jul 7, 2020
...s-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonMemberDeserVisitor.java
Outdated
Show resolved
Hide resolved
JordonPhillips
changed the title
skotambkar
approved these changes
Jul 7, 2020
...ws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonShapeDeserVisitor.java
Show resolved
Hide resolved
...thy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AwsProtocolUtils.java
Show resolved
Hide resolved
jasdel
approved these changes
Jul 7, 2020
kstich
suggested changes
Jul 9, 2020
...ws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonShapeDeserVisitor.java
Outdated
Show resolved
Hide resolved
...ws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonShapeDeserVisitor.java
Show resolved
Hide resolved
...go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonRpcProtocolGenerator.java
Show resolved
Hide resolved
kstich
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add support for the json rpc protocols. Some work has been done to extract json serde out of the rest protocol, though the source hasn't yet been removed. This requires this pr to function at all.