Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cloudfront example usage of SignWithPolicy #673

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Fix cloudfront example usage of SignWithPolicy #673

merged 1 commit into from
Sep 30, 2020

Conversation

cmoog
Copy link
Contributor

@cmoog cmoog commented Aug 16, 2020

Closes #671

@jasdel
Copy link
Contributor

jasdel commented Aug 31, 2020

Thanks for creating this PR @cmoog. We'll want to rebase this change to the feature/SmithyAPIClient branch as it is the working branch that will be merged into master once the API clients are being generated for more services. We can also do this after we merge the feature/SmithyAPIClient branch into master.

jasdel
jasdel approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to create this PR @cmoog we'll get this change merged in and included in a tagged release.

@jasdel jasdel merged commit ffe8290 into aws:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdel jasdel jasdel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in CloudFront sign utility for SignWithPolicy.
2 participants
@cmoog @jasdel