Support json union deserialization #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
reviewed
Aug 21, 2020
...ws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonShapeDeserVisitor.java
Outdated
Show resolved
Hide resolved
...ws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonShapeDeserVisitor.java
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
deserialize-unions
branch
from
5d11272 to
943b627
Compare
skmcgrail
force-pushed
the
feature/SmithyAPIClient
branch
from
5c6e32b to
bc56465
Compare
skmcgrail
force-pushed
the
deserialize-unions
branch
from
943b627 to
887e459
Compare
JordonPhillips
force-pushed
the
deserialize-unions
branch
from
887e459 to
7b8d5ad
Compare
JordonPhillips
force-pushed
the
deserialize-unions
branch
from
8ae33d2 to
eb37bff
Compare
jasdel
approved these changes
Aug 26, 2020
...ws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonShapeDeserVisitor.java
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
deserialize-unions
branch
from
eb37bff to
1eb47fb
Compare
JordonPhillips
force-pushed
the
deserialize-unions
branch
from
1eb47fb to
bd96d3e
Compare
jasdel
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for deserializing json unions and fixes serialization of the same. This depends on the following PRS:
aws/smithy-go#146 (updates union generation)
smithy-lang/smithy#536 (adds protocol tests)