Override ml endpoint with PredictEndpoint if set #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
reviewed
Sep 30, 2020
| // AddPredictEndpointMiddleware adds the middleware required to set the endpoint | ||
| // based on Predict's PredictEndpoint input member. | ||
| func AddPredictEndpointMiddleware(stack *middleware.Stack, endpoint fetchPredictEndpointFunc) { | ||
| stack.Serialize.Insert(&predictEndpointMiddleware{}, "ResolveEndpoint", middleware.After) |
There was a problem hiding this comment.
At some point we need to figure out a strategy for these middleware IDs and be constants somehow. Potentially with middleware slots, this may be easier. aws/smithy-go#156
service/machinelearning/internal/customizations/predictendpoint.go
Outdated
Show resolved
Hide resolved
service/machinelearning/internal/customizations/predictendpoint.go
Outdated
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
machine-learning-endpoint
branch
from
827e3de
to
636306b
Compare
JordonPhillips
force-pushed
the
machine-learning-endpoint
branch
from
636306b
to
46e66c1
Compare
jasdel
approved these changes
Oct 1, 2020
jasdel
reviewed
Oct 1, 2020
JordonPhillips
force-pushed
the
machine-learning-endpoint
branch
from
46e66c1
to
1da55fa
Compare
jasdel
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.