Refactor Config Module, Add Config Package Documentation and Examples, Improve Overall SDK Readme #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
force-pushed
the
configCleanup
branch
from
a38635c
to
9625c95
Compare
jasdel
approved these changes
Oct 14, 2020
skmcgrail
force-pushed
the
configCleanup
branch
from
9625c95
to
ac52f93
Compare
jasdel
reviewed
Oct 16, 2020
Comment on lines
+356
to
+365
| // WithWebIdentityRoleCredentialOptions wraps a function and satisfies the EC2RoleCredentialOptionsProvider interface | ||
| type WithWebIdentityRoleCredentialOptions func(*stscreds.WebIdentityRoleOptions) | ||
|
|
||
| // GetWebIdentityCredentialProviderOptions returns the wrapped function | ||
| func (w WithWebIdentityCredentialProviderOptions) GetWebIdentityCredentialProviderOptions() (func(*stscreds.WebIdentityRoleOptions), bool, error) { | ||
| // GetWebIdentityRoleCredentialOptions returns the wrapped function | ||
| func (w WithWebIdentityRoleCredentialOptions) GetWebIdentityRoleCredentialOptions() (func(*stscreds.WebIdentityRoleOptions), bool, error) { | ||
| return w, true, nil | ||
| } | ||
|
|
||
| // GetWebIdentityCredentialProviderOptions searches the slice of configs and returns the first function found | ||
| func GetWebIdentityCredentialProviderOptions(configs Configs) (f func(*stscreds.WebIdentityRoleOptions), found bool, err error) { | ||
| // getWebIdentityCredentialProviderOptions searches the slice of configs and returns the first function found | ||
| func getWebIdentityCredentialProviderOptions(configs configs) (f func(*stscreds.WebIdentityRoleOptions), found bool, err error) { |
There was a problem hiding this comment.
Should rename the private getter as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored config module, add config package documentation and examples, and improved the overall SDK readme.